[Mlir-commits] [llvm] [mlir] [NFC][TableGen] Use `Twine` for Name argument in CodeGenHelpers (PR #163581)

Mehdi Amini llvmlistbot at llvm.org
Thu Oct 16 13:02:03 PDT 2025


================
@@ -54,8 +54,8 @@ class IncludeGuardEmitter {
 // namespace scope.
 class NamespaceEmitter {
 public:
-  NamespaceEmitter(raw_ostream &OS, StringRef NameUntrimmed)
-      : Name(trim(NameUntrimmed).str()), OS(OS) {
+  NamespaceEmitter(raw_ostream &OS, const Twine &NameTwine)
+      : Name(trim(NameTwine)), OS(OS) {
----------------
joker-eph wrote:

Nit: the original name for the variable was more specific to the intent IMO, not sure the type change needs a name change here.

https://github.com/llvm/llvm-project/pull/163581


More information about the Mlir-commits mailing list