[Mlir-commits] [mlir] [Linalg] Add matchers to infer which Convolution Op a given linalg.generic is (PR #163374)

[Renato Golin]

rengolin wrote:

Thanks @hanhanW for the context around IREE. This is one of the key design decisions behind the [Linalg Forms](https://mlir.llvm.org/docs/Rationale/RationaleLinalgDialect/#interchangeability-of-formsa-nameformsa). 

Adding my side to it: While the background motivation for this particular PR is to improve IREE, the matchers themselves are useful on their own for all other upstream and downstream users to be able to convert between the forms and simplify their matching infrastructure.

I'll let @javedabsar1 review the code and approve, but I like your public API using just one template argument and two function arguments. While the (static) implementation is still very verbose, the outward facing design is very clean. We can improve the private implementation with time, independent of being able to use this already upstream. Thanks!

https://github.com/llvm/llvm-project/pull/163374