[Mlir-commits] [mlir] [mlir][bufferize] Make drop-equivalent-buffer-results only support functions that are neither public nor extern (PR #163001)

[Isaac Nudelman]

nuudlman wrote:

The documentation of this pass implies that it is used for enforcing calling conventions:
> Some calling conventions prefer to pass output memrefs as "out params". The
    conversion to this calling convention must be done as an atomic
    transformation of the entire program (hence this is a module pass).

Our internal target uses this pass to enforce a valid calling convention for MLIR, and I believe that many users of EmitC will also be using this as iirc EmitC doesn't support functions that return memrefs.

To be clear, this change *completely breaks* our downstream target, so we would highly appreciate if there was a way to opt out.

https://github.com/llvm/llvm-project/pull/163001