[Mlir-commits] [mlir] [mlir][python] add dict-style to IR attributes (PR #163200)

[Renato Golin]

rengolin wrote:

This:

> If you're improving the UX of an API we should instead deprecate and replace, then I don't agree.

And:

> The "migration" as you call it has been on going for two years and no one of the migrators has made any attempt to produce a working alternative to what we in the bindings have now

And:

> That would seem to require a superset of what Nanobind can do (automatically generate C API and then generate Python API to access arbitrary C++ via C API). That seems really tricky. Attributes work as most are built up of very simple and constrained set. This is a hard blocker for migration to Properties but not related to this change IMHO.

Are really strong reasons to accept this change for what it is, allowing current users (attributes) to have a better experience, since there's no telling when (or even _if_) the migration to properties will happen.

This is a common situation in LLVM, where multiple implementations co-exist for some time, and it's up to the maintainers to keep up with the churn. Since @makslevental volunteered to do that work, I see no reason to block this PR from merging.

https://github.com/llvm/llvm-project/pull/163200