[Mlir-commits] [mlir] [mlir][spirv] Fix test (NFC) (PR #163413)

Erick Ochoa Lopez llvmlistbot at llvm.org
Tue Oct 14 08:33:14 PDT 2025


https://github.com/amd-eochoalo created https://github.com/llvm/llvm-project/pull/163413

This test had a CHECK-RAW command. The intention behind this command appears to be to avoid using the regular expression matching capabilities. However, this was interpretted as a comment by FileCheck. In order to check for literal strings the {LITERAL} modifier should be used. https://llvm.org/docs/CommandGuide/FileCheck.html#directive-modifiers

>From 4ec33c1adc1027b7dcd26436b587905a0f8c3875 Mon Sep 17 00:00:00 2001
From: Erick Ochoa <erick.ochoalopez at amd.com>
Date: Tue, 14 Oct 2025 11:30:49 -0400
Subject: [PATCH] [mlir][spirv] Fix test (NFC)

This test had a CHECK-RAW command. The intention behind this command
appears to be to avoid using the regular expression matching
capabilities. However, this was interpretted as a comment by FileCheck.
In order to check for literal strings the {LITERAL} modifier should be
used. https://llvm.org/docs/CommandGuide/FileCheck.html#directive-modifiers
---
 mlir/test/Integration/GPU/SPIRV/simple_add.mlir | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/mlir/test/Integration/GPU/SPIRV/simple_add.mlir b/mlir/test/Integration/GPU/SPIRV/simple_add.mlir
index cb16c376eaa6f..b3154d4b91516 100644
--- a/mlir/test/Integration/GPU/SPIRV/simple_add.mlir
+++ b/mlir/test/Integration/GPU/SPIRV/simple_add.mlir
@@ -3,7 +3,16 @@
 // RUN: | FileCheck %s
 
 // CHECK: data =
-// CHECK-RAW: [[[7.7,    0,    0], [7.7,    0,    0], [7.7,    0,    0]], [[0,    7.7,    0], [0,    7.7,    0], [0,    7.7,    0]], [[0,    0,    7.7], [0,    0,    7.7], [0,    0,    7.7]]]
+// CHECK{LITERAL}: [[[7.7,    0,    0],
+// CHECK{LITERAL}: [7.7,    0,    0],
+// CHECK{LITERAL}: [7.7,    0,    0]],
+// CHECK{LITERAL}: [[0,    7.7,    0],
+// CHECK{LITERAL}: [0,    7.7,    0],
+// CHECK{LITERAL}: [0,    7.7,    0]],
+// CHECK{LITERAL}: [[0,    0,    7.7],
+// CHECK{LITERAL}: [0,    0,    7.7],
+// CHECK{LITERAL}: [0,    0,    7.7]]]
+
 module attributes {
   gpu.container_module,
   spirv.target_env = #spirv.target_env<



More information about the Mlir-commits mailing list