[Mlir-commits] [mlir] [mlir][linalg] Extend DecomposeOuterUnitDimsPackOpPattern (linalg.pack) (PR #162666)

[Andrzej Warzyński]

================
@@ -1160,10 +1157,14 @@ LogicalResult DecomposeOuterUnitDimsPackOpPattern::matchAndRewrite(
   //    %transposed_tile = linalg.transpose ins(%source_or_padded_source),
   //                                        outs(%init)
   // Assumptions made:
-  //  - All outer dims are 1 - the corresponding transposition order doesn't
-  //     matter, but requires all dim indices to be present.
-
-  // 2.1 Get the permutation for linalg.transpose
+  //  - All tiled outer dims are 1 - the corresponding transposition order
+  //    doesn't matter, but requires all dim indices to be present.
+  //  - Un-tiled outer dims remain un-permuted. (TODO: Fail when this does not
----------------
banach-space wrote:

Thanks for the suggestion, updated in the latest commit!

https://github.com/llvm/llvm-project/pull/162666