https://github.com/rengolin commented: This looks ok to me, too. It's a bit verbose and repetitive, but that's the nature of these conversion patterns, not much we can do. Tests look thorough, that's nice. https://github.com/llvm/llvm-project/pull/159878