[Mlir-commits] [mlir] [MLIR][LLVM] Add bytecode support for several attributes (PR #162577)

[Bruno Cardoso Lopes]

bcardosolopes wrote:

Thanks for the fast review!

> What does happen if we will modify an attribute in the future. Will there be some kind of compilation error if we forget to update the bytecode equivalent?

Not in the way we'd like (a nice tablegen choke perhaps) but because these tablegen generate call to the builders, we'd get an error for the builder call mismatch, which is not ideal but works (for most part?). Note that the [first extra commit](https://github.com/llvm/llvm-project/pull/162577/commits/aa91a1abc7283626694e3168297295b740ac6a3b) in this PR was due to exactly this: when bringing the work upstream, `DICompositeTypeAttr` had a different order and that was caught at build time.

https://github.com/llvm/llvm-project/pull/162577