[Mlir-commits] [mlir] [MLIR][Transform][SMT] Allow for declarative computations in schedules (PR #160895)

[Rolf Morel]

rolfmorel wrote:

Thanks for the review, @ftynse! I addressed your comments. 

Note that my current understanding is that the terminator does need to be checked in `verify()`. Also note that the following error case is currently not triggerable as `!transform.param<T>` verifier enforces that `T` must an integer type. When this is relaxed, the following check will be useful and triggerable.

```
    if (isa<mlir::smt::IntType>(smtType)) {
      if (!isa<IntegerType>(typeWrappedByParam))
        return op->emitOpError()
               << "the type of " << smtDesc << " #" << idx
               << " is !smt.int though the corresponding " << paramDesc
               << " type (" << paramType << ") is not wrapping an integer type";
```

Will land in a day or so, unless I hear otherwise.

(Edit: for some reason the PR is not picking up the new commit from my branch: https://github.com/llvm/llvm-project/compare/main...rolfmorel:llvm-project:smt.constrain_params - will pay extra attention to that the right commits will get merged.)

https://github.com/llvm/llvm-project/pull/160895