[Mlir-commits] [mlir] [mlir] Execute same operand name constraints before user constraints. (PR #162526)

[Logan Chien]

================
@@ -1024,6 +1024,32 @@ void PatternEmitter::emitMatchLogic(DagNode tree, StringRef opName) {
   int depth = 0;
   emitMatch(tree, opName, depth);
 
+  // Some of the operands could be bound to the same symbol name, we need
+  // to enforce equality constraint on those.
+  // This has to happen before user provided constraints, which may assume the
+  // same name checks are already performed, since in the pattern source code
+  // the user provided constraints appear later.
+  // TODO: we should be able to emit equality checks early
----------------
loganchien wrote:

It seems that this TODO can be removed because this PR fixes the order.

https://github.com/llvm/llvm-project/pull/162526