[Mlir-commits] [mlir] [ROCDL] Added missing named barrier ops (gfx1250) (PR #162488)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Wed Oct 8 07:20:49 PDT 2025
https://github.com/ravil-mobile created https://github.com/llvm/llvm-project/pull/162488
This patch introduces some missing s.barrier instructions in the ROCDL dialect handling named barriers
Specifically:
```
@llvm.amdgcn.s.barrier.init - s_barrier_init
@llvm.amdgcn.s.barrier.join - s_barrier_join
@llvm.amdgcn.s.barrier.leave - s_barrier_leave
@llvm.amdgcn.s.barrier.signal.isfirst - s_barrier_signal_isfirst
```
Tests:
- Added lit-tests to check MLIR -> LLVM lowering
cc @krzysz00, @amd-eochoalo
>From 5ea786dd3cdcfcff0e01df4d2d93eb63ab22dcb9 Mon Sep 17 00:00:00 2001
From: ravil-mobile <ravil.aviva.com at gmail.com>
Date: Wed, 8 Oct 2025 14:07:01 +0000
Subject: [PATCH] [ROCDL] Added missing named barrier ops (gfx1250)
---
mlir/include/mlir/Dialect/LLVMIR/ROCDLOps.td | 33 +++++++++++++++++-
mlir/test/Dialect/LLVMIR/rocdl.mlir | 35 ++++++++++++++++++++
mlir/test/Target/LLVMIR/rocdl.mlir | 35 ++++++++++++++++++++
3 files changed, 102 insertions(+), 1 deletion(-)
diff --git a/mlir/include/mlir/Dialect/LLVMIR/ROCDLOps.td b/mlir/include/mlir/Dialect/LLVMIR/ROCDLOps.td
index db1b7e3af62fd..7560b61137afc 100644
--- a/mlir/include/mlir/Dialect/LLVMIR/ROCDLOps.td
+++ b/mlir/include/mlir/Dialect/LLVMIR/ROCDLOps.td
@@ -292,18 +292,50 @@ def ROCDL_BarrierOp : ROCDL_Op<"barrier"> {
let assemblyFormat = "attr-dict";
}
+def ROCDLBufferLDS : LLVM_PointerInAddressSpace<3>;
+
+def ROCDL_BarrierInitOp : ROCDL_IntrOp<"s.barrier.init", [], [], [Pure], 0, 0, 0, 0, [1], ["id"]>,
+ Arguments<(ins Arg<ROCDLBufferLDS, "", [MemRead]>:$ptr, I32Attr:$id)> {
+ let results = (outs);
+ let assemblyFormat = "$ptr `,` $id attr-dict";
+}
+
def ROCDL_BarrierSignalOp : ROCDL_ConcreteNonMemIntrOp<"s.barrier.signal", [], 0, [0], ["id"]>,
Arguments<(ins I32Attr:$id)> {
let results = (outs);
let assemblyFormat = "$id attr-dict";
}
+def ROCDL_BarrierSignalVarOp : ROCDL_IntrOp<"s.barrier.signal.var", [], [], [Pure], 0, 0, 0, 0, [1], ["id"]>,
+ Arguments<(ins Arg<ROCDLBufferLDS, "", [MemRead]>:$ptr, I32Attr:$id)> {
+ let results = (outs);
+ let assemblyFormat = "$ptr `,` $id attr-dict";
+}
+
+def ROCDL_BarrierJoinOp : ROCDL_IntrOp<"s.barrier.join", [], [], [Pure], 0>,
+ Arguments<(ins Arg<ROCDLBufferLDS, "", [MemRead]>:$ptr)> {
+ let results = (outs);
+ let assemblyFormat = "$ptr attr-dict";
+}
+
+def ROCDL_BarrierLeaveOp : ROCDL_ConcreteNonMemIntrOp<"s.barrier.leave", [], 0, [0], ["id"]>,
+ Arguments<(ins I16Attr:$id)> {
+ let results = (outs);
+ let assemblyFormat = "$id attr-dict";
+}
+
def ROCDL_BarrierWaitOp : ROCDL_ConcreteNonMemIntrOp<"s.barrier.wait", [], 0, [0], ["id"]>,
Arguments<(ins I16Attr:$id)> {
let results = (outs);
let assemblyFormat = "$id attr-dict";
}
+def ROCDL_BarrierSignalIsfirstOp : ROCDL_ConcreteNonMemIntrOp<"s.barrier.signal.isfirst", [], 1, [0], ["id"]>,
+ Arguments<(ins I32Attr:$id)> {
+ let results = (outs I1:$res);
+ let assemblyFormat = "$id attr-dict `:` type($res)";
+}
+
def ROCDL_WaitDscntOp: ROCDL_ConcreteNonMemIntrOp<"s.wait.dscnt", [], 0, [0], ["count"]>,
Arguments<(ins I16Attr:$count)> {
let summary = "Wait until DSCNT is less than or equal to `count`";
@@ -497,7 +529,6 @@ def ROCDL_wmma_i32_16x16x32_iu4 : ROCDL_Wmma_IntrOp<"wmma.i32.16x16x32.iu4", [1]
// LDS transpose intrinsics (available in GFX950)
def ROCDLGlobalBuffer : LLVM_PointerInAddressSpace<1>;
-def ROCDLBufferLDS : LLVM_PointerInAddressSpace<3>;
class ROCDL_LDS_Read_Tr_IntrOp<string mnemonic> :
ROCDL_IntrOp<mnemonic, [1], [], [], 1, 0, 1> {
diff --git a/mlir/test/Dialect/LLVMIR/rocdl.mlir b/mlir/test/Dialect/LLVMIR/rocdl.mlir
index a88b59aeb61b2..9e13baf77a689 100644
--- a/mlir/test/Dialect/LLVMIR/rocdl.mlir
+++ b/mlir/test/Dialect/LLVMIR/rocdl.mlir
@@ -951,6 +951,13 @@ llvm.func @rocdl.s.barrier() {
llvm.return
}
+llvm.func @rocdl.s.barrier.init(%ptr : !llvm.ptr<3>) {
+ // CHECK-LABEL: rocdl.s.barrier.init
+ // CHECK: rocdl.s.barrier.init %[[PTR:.+]], 1
+ rocdl.s.barrier.init %ptr, 1
+ llvm.return
+}
+
llvm.func @rocdl.s.barrier.signal() {
// CHECK-LABEL: rocdl.s.barrier.signal
// CHECK: rocdl.s.barrier.signal -1
@@ -958,6 +965,27 @@ llvm.func @rocdl.s.barrier.signal() {
llvm.return
}
+llvm.func @rocdl.s.barrier.signal.var(%ptr : !llvm.ptr<3>) {
+ // CHECK-LABEL: rocdl.s.barrier.signal.var
+ // CHECK: rocdl.s.barrier.signal.var %[[PTR:.+]], 1
+ rocdl.s.barrier.signal.var %ptr, 1
+ llvm.return
+}
+
+llvm.func @rocdl.s.barrier.join(%ptr : !llvm.ptr<3>) {
+ // CHECK-LABEL: rocdl.s.barrier.join
+ // CHECK: rocdl.s.barrier.join %[[PTR:.+]]
+ rocdl.s.barrier.join %ptr
+ llvm.return
+}
+
+llvm.func @rocdl.s.barrier.leave() {
+ // CHECK-LABEL: rocdl.s.barrier.leave
+ // CHECK: rocdl.s.barrier.leave 1
+ rocdl.s.barrier.leave 1
+ llvm.return
+}
+
llvm.func @rocdl.s.barrier.wait() {
// CHECK-LABEL: rocdl.s.barrier.wait
// CHECK: rocdl.s.barrier.wait -1
@@ -965,6 +993,13 @@ llvm.func @rocdl.s.barrier.wait() {
llvm.return
}
+llvm.func @rocdl.s.barrier.signal.isfirst() {
+ // CHECK-LABEL: rocdl.s.barrier.signal.isfirst
+ // CHECK: rocdl.s.barrier.signal.isfirst 1
+ %0 = rocdl.s.barrier.signal.isfirst 1 : i1
+ llvm.return
+}
+
llvm.func @rocdl.s.wait.dscnt() {
// CHECK-LABEL: rocdl.s.wait.dscnt
// CHECK: rocdl.s.wait.dscnt 0
diff --git a/mlir/test/Target/LLVMIR/rocdl.mlir b/mlir/test/Target/LLVMIR/rocdl.mlir
index 1c0c2eba002aa..3eb404bcb8a40 100644
--- a/mlir/test/Target/LLVMIR/rocdl.mlir
+++ b/mlir/test/Target/LLVMIR/rocdl.mlir
@@ -192,6 +192,13 @@ llvm.func @rocdl.barrier() {
llvm.return
}
+llvm.func @rocdl.s.barrier.init(%ptr : !llvm.ptr<3>) {
+ // CHECK-LABEL: rocdl.s.barrier.init
+ // CHECK: call void @llvm.amdgcn.s.barrier.init(ptr addrspace(3) %[[PTR:.+]], i32 1)
+ rocdl.s.barrier.init %ptr, 1
+ llvm.return
+}
+
llvm.func @rocdl.s.barrier.signal() {
// CHECK-LABEL: rocdl.s.barrier.signal
// CHECK-NEXT: call void @llvm.amdgcn.s.barrier.signal(i32 -1)
@@ -199,6 +206,27 @@ llvm.func @rocdl.s.barrier.signal() {
llvm.return
}
+llvm.func @rocdl.s.barrier.signal.var(%ptr : !llvm.ptr<3>) {
+ // CHECK-LABEL: rocdl.s.barrier.signal.var
+ // CHECK: call void @llvm.amdgcn.s.barrier.signal.var(ptr addrspace(3) %[[PTR:.+]], i32 1)
+ rocdl.s.barrier.signal.var %ptr, 1
+ llvm.return
+}
+
+llvm.func @rocdl.s.barrier.join(%ptr : !llvm.ptr<3>) {
+ // CHECK-LABEL: rocdl.s.barrier.join
+ // CHECK: call void @llvm.amdgcn.s.barrier.join(ptr addrspace(3) %[[PTR:.+]])
+ rocdl.s.barrier.join %ptr
+ llvm.return
+}
+
+llvm.func @rocdl.s.barrier.leave() {
+ // CHECK-LABEL: rocdl.s.barrier.leave
+ // CHECK: call void @llvm.amdgcn.s.barrier.leave(i16 1)
+ rocdl.s.barrier.leave 1
+ llvm.return
+}
+
llvm.func @rocdl.s.barrier.wait() {
// CHECK-LABEL: rocdl.s.barrier.wait
// CHECK-NEXT: call void @llvm.amdgcn.s.barrier.wait(i16 -1)
@@ -206,6 +234,13 @@ llvm.func @rocdl.s.barrier.wait() {
llvm.return
}
+llvm.func @rocdl.s.barrier.signal.isfirst() {
+ // CHECK-LABEL: rocdl.s.barrier.signal.isfirst
+ // CHECK: %[[OUT:.+]] = call i1 @llvm.amdgcn.s.barrier.signal.isfirst(i32 1)
+ %0 = rocdl.s.barrier.signal.isfirst 1 : i1
+ llvm.return
+}
+
llvm.func @rocdl.s.wait.dscnt() {
// CHECK-LABEL: rocdl.s.wait.dscnt
// CHECK-NEXT: call void @llvm.amdgcn.s.wait.dscnt(i16 0)
More information about the Mlir-commits
mailing list