[Mlir-commits] [mlir] [MLIR][Vector] Added ToElementsOp::fold for broadcast->to_elements pattern rewrite. (PR #160318)

[David Spickett]

DavidSpickett wrote:

This has caused test failures on AArch64: https://lab.llvm.org/buildbot/#/builders/143/builds/11524

One example:
```
******************** TEST 'MLIR :: Integration/Dialect/Tensor/dim-runtime-verification.mlir' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
/home/tcwg-buildbot/worker/clang-aarch64-sve-vls/stage1/bin/mlir-opt /home/tcwg-buildbot/worker/clang-aarch64-sve-vls/llvm/mlir/test/Integration/Dialect/Tensor/dim-runtime-verification.mlir -generate-runtime-verification      -one-shot-bufferize="bufferize-function-boundaries"      -buffer-deallocation-pipeline=private-function-dynamic-ownership      -test-cf-assert      -convert-to-llvm |  /home/tcwg-buildbot/worker/clang-aarch64-sve-vls/stage1/bin/mlir-runner -e main -entry-point-result=void      -shared-libs=/home/tcwg-buildbot/worker/clang-aarch64-sve-vls/stage1/tools/mlir/test/Integration/Dialect/Tensor/Output/dim-runtime-verification.mlir.tmplir_runner_utils 2>&1 |  /home/tcwg-buildbot/worker/clang-aarch64-sve-vls/stage1/bin/FileCheck /home/tcwg-buildbot/worker/clang-aarch64-sve-vls/llvm/mlir/test/Integration/Dialect/Tensor/dim-runtime-verification.mlir
# executed command: /home/tcwg-buildbot/worker/clang-aarch64-sve-vls/stage1/bin/mlir-opt /home/tcwg-buildbot/worker/clang-aarch64-sve-vls/llvm/mlir/test/Integration/Dialect/Tensor/dim-runtime-verification.mlir -generate-runtime-verification -one-shot-bufferize=bufferize-function-boundaries -buffer-deallocation-pipeline=private-function-dynamic-ownership -test-cf-assert -convert-to-llvm
# executed command: /home/tcwg-buildbot/worker/clang-aarch64-sve-vls/stage1/bin/mlir-runner -e main -entry-point-result=void -shared-libs=/home/tcwg-buildbot/worker/clang-aarch64-sve-vls/stage1/tools/mlir/test/Integration/Dialect/Tensor/Output/dim-runtime-verification.mlir.tmplir_runner_utils
# executed command: /home/tcwg-buildbot/worker/clang-aarch64-sve-vls/stage1/bin/FileCheck /home/tcwg-buildbot/worker/clang-aarch64-sve-vls/llvm/mlir/test/Integration/Dialect/Tensor/dim-runtime-verification.mlir
# .---command stderr------------
# | /home/tcwg-buildbot/worker/clang-aarch64-sve-vls/llvm/mlir/test/Integration/Dialect/Tensor/dim-runtime-verification.mlir:25:17: error: CHECK-NEXT: expected string not found in input
# |  // CHECK-NEXT: "tensor.dim"(%{{.*}}, %{{.*}}) : (tensor<1xf32>, index) -> index
# |                 ^
# | <stdin>:3:38: note: scanning from here
# | ERROR: Runtime op verification failed
# |                                      ^
# | <stdin>:4:8: note: possible intended match here
# | %dim = tensor.dim %0, %c4 : tensor<1xf32>
# |        ^
# | 
# | Input file: <stdin>
# | Check file: /home/tcwg-buildbot/worker/clang-aarch64-sve-vls/llvm/mlir/test/Integration/Dialect/Tensor/dim-runtime-verification.mlir
# | 
# | -dump-input=help explains the following input dump.
# | 
# | Input was:
# | <<<<<<
# |            1: Failed to create MemoryBuffer for: /home/tcwg-buildbot/worker/clang-aarch64-sve-vls/stage1/tools/mlir/test/Integration/Dialect/Tensor/Output/dim-runtime-verification.mlir.tmplir_runner_utils 
# |            2: Error: No such file or directory 
# |            3: ERROR: Runtime op verification failed 
# | next:25'0                                          X error: no match found
# |            4: %dim = tensor.dim %0, %c4 : tensor<1xf32> 
# | next:25'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# | next:25'1            ?                                   possible intended match
# |            5: ^ 
# | next:25'0     ~~
# |            6: Location: loc("/home/tcwg-buildbot/worker/clang-aarch64-sve-vls/llvm/mlir/test/Integration/Dialect/Tensor/dim-runtime-verification.mlir":28:10) 
# | next:25'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# | >>>>>>
# `-----------------------------
# error: command failed with exit status: 1

--

********************
```
The host does have SVE vector extensions, and if this is running code, it's running natively.

Also please set your email settings (https://llvm.org/docs/DeveloperPolicy.html#email-addresses) for future contributions so that you are notified.

(notifications are only posted on PRs if that PR is the only change included in a build)


https://github.com/llvm/llvm-project/pull/160318