[Mlir-commits] [llvm] [mlir] [ROCDL] Add gfx1250 WMMA intrinsics (PR #162343)

[Krzysztof Drewniak]

krzysz00 wrote:

@Muzammiluddin-Syed-ECE Yes, that code looks correct

That being said, While You're Here (tm) ... would it be possible to actually list out the WMMA signatures instead of just using a variadic set of arguments? (Yes, that'll mean more than one template - you can probably borrow names off of LLVM. It'll also let us encode the AllTypesMatch<["x", "y"]> that the LLVM definitions imply). You might not need to change the syntax, but it'll make it harder to construct invalid IR. It'll also let us use `Attribute`s for `immarg`s like we should.

https://github.com/llvm/llvm-project/pull/162343