[Mlir-commits] [mlir] [MLIR][Python] hide globals in ir.py (PR #162339)

[llvmlistbot at llvm.org]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-mlir

Author: Maksim Levental (makslevental)

<details>
<summary>Changes</summary>

We're shadowing the Python builtin function `globals` in `ir.py` and therefore anywhere someone does `from mlir.ir import *`. So hide it.

---
Full diff: https://github.com/llvm/llvm-project/pull/162339.diff


1 Files Affected:

- (modified) mlir/python/mlir/ir.py (+7-7) 


``````````diff
diff --git a/mlir/python/mlir/ir.py b/mlir/python/mlir/ir.py
index 7ddc70a35af96..11477d061e897 100644
--- a/mlir/python/mlir/ir.py
+++ b/mlir/python/mlir/ir.py
@@ -12,7 +12,7 @@
 from ._mlir_libs._mlir import (
     register_type_caster,
     register_value_caster,
-    globals,
+    globals as _globals,
 )
 from ._mlir_libs import (
     get_dialect_registry,
@@ -32,17 +32,17 @@ def loc_tracebacks(*, max_depth: int | None = None) -> Iterable[None]:
       max_depth: Maximum number of frames to include in the location.
         If None, the default limit is used.
     """
-    old_enabled = globals.loc_tracebacks_enabled()
-    old_limit = globals.loc_tracebacks_frame_limit()
+    old_enabled = _globals.loc_tracebacks_enabled()
+    old_limit = _globals.loc_tracebacks_frame_limit()
     try:
-        globals.set_loc_tracebacks_frame_limit(max_depth)
+        _globals.set_loc_tracebacks_frame_limit(max_depth)
         if not old_enabled:
-            globals.set_loc_tracebacks_enabled(True)
+            _globals.set_loc_tracebacks_enabled(True)
             yield
     finally:
         if not old_enabled:
-            globals.set_loc_tracebacks_enabled(False)
-        globals.set_loc_tracebacks_frame_limit(old_limit)
+            _globals.set_loc_tracebacks_enabled(False)
+        _globals.set_loc_tracebacks_frame_limit(old_limit)
 
 
 # Convenience decorator for registering user-friendly Attribute builders.

``````````

</details>


https://github.com/llvm/llvm-project/pull/162339