[Mlir-commits] [mlir] [mlir][bufferization][NFC] Rename `resultBufferizesToMemoryWrite` (PR #162233)
Matthias Springer
llvmlistbot at llvm.org
Tue Oct 7 00:18:21 PDT 2025
https://github.com/matthias-springer updated https://github.com/llvm/llvm-project/pull/162233
>From 1259097670e19b7b07d05c68b9bae8850837d9f0 Mon Sep 17 00:00:00 2001
From: Matthias Springer <me at m-sp.org>
Date: Tue, 7 Oct 2025 07:14:59 +0000
Subject: [PATCH] [mlir][bufferization][NFC] Rename
`resultBufferizesToMemoryWrite`
---
.../Dialect/Bufferization/IR/BufferizableOpInterface.h | 6 +++---
.../Bufferization/IR/BufferizableOpInterface.td | 10 +++++-----
.../mlir/Dialect/Bufferization/IR/BufferizationOps.td | 4 ++--
.../Bufferization/IR/BufferizableOpInterface.cpp | 4 ++--
mlir/lib/Dialect/Bufferization/IR/BufferizationOps.cpp | 4 ++--
.../Transforms/BufferizableOpInterfaceImpl.cpp | 4 ++--
.../Tensor/Transforms/BufferizableOpInterfaceImpl.cpp | 4 ++--
7 files changed, 18 insertions(+), 18 deletions(-)
diff --git a/mlir/include/mlir/Dialect/Bufferization/IR/BufferizableOpInterface.h b/mlir/include/mlir/Dialect/Bufferization/IR/BufferizableOpInterface.h
index dd693a25fd54f..0dde0a8e1d528 100644
--- a/mlir/include/mlir/Dialect/Bufferization/IR/BufferizableOpInterface.h
+++ b/mlir/include/mlir/Dialect/Bufferization/IR/BufferizableOpInterface.h
@@ -720,10 +720,10 @@ defaultGetBufferType(Value value, const BufferizationOptions &options,
SmallVector<Value> &invocationStack);
/// This is the default implementation of
-/// BufferizableOpInterface::resultBufferizesToMemoryWrite. Should not be called
+/// BufferizableOpInterface::bufferizesToMemoryWrite. Should not be called
/// from other places.
-bool defaultResultBufferizesToMemoryWrite(OpResult opResult,
- const AnalysisState &state);
+bool defaultBufferizesToMemoryWrite(OpResult opResult,
+ const AnalysisState &state);
/// This is the default implementation of
/// BufferizableOpInterface::isRepetitiveRegion. Should not be called from other
diff --git a/mlir/include/mlir/Dialect/Bufferization/IR/BufferizableOpInterface.td b/mlir/include/mlir/Dialect/Bufferization/IR/BufferizableOpInterface.td
index 246ae77f327cf..3c713e0aa8869 100644
--- a/mlir/include/mlir/Dialect/Bufferization/IR/BufferizableOpInterface.td
+++ b/mlir/include/mlir/Dialect/Bufferization/IR/BufferizableOpInterface.td
@@ -148,8 +148,8 @@ def BufferizableOpInterface : OpInterface<"BufferizableOpInterface"> {
InterfaceMethod<
/*desc=*/[{
Return `true` if the given OpResult bufferizes to a memory write.
- This is the same property as `bufferizesToMemoryWrite`, but from The
- perspective of OpResults.
+ This is the same property as `bufferizesToMemoryWrite(OpOperand &)`,
+ but from the perspective of OpResults.
This method will never be called on OpResults that do not have a
tensor type.
@@ -165,7 +165,7 @@ def BufferizableOpInterface : OpInterface<"BufferizableOpInterface"> {
Counter-example: bufferization.alloc_tensor
The op just allocates and does not specify the data of the tensor,
- so resultBufferizesToMemoryWrite is overridden to return false.
+ so `bufferizesToMemoryWrite` is overridden to return false.
2. At least one aliasing OpOperand bufferizes to a memory write.
@@ -192,14 +192,14 @@ def BufferizableOpInterface : OpInterface<"BufferizableOpInterface"> {
write.
}],
/*retType=*/"bool",
- /*methodName=*/"resultBufferizesToMemoryWrite",
+ /*methodName=*/"bufferizesToMemoryWrite",
/*args=*/(ins "::mlir::OpResult":$opResult,
"const ::mlir::bufferization::AnalysisState &":$state),
/*methodBody=*/"",
/*defaultImplementation=*/[{
assert(opResult.getDefiningOp() == $_op.getOperation() &&
"invalid OpResult");
- return ::mlir::bufferization::detail::defaultResultBufferizesToMemoryWrite(
+ return ::mlir::bufferization::detail::defaultBufferizesToMemoryWrite(
opResult, state);
}]
>,
diff --git a/mlir/include/mlir/Dialect/Bufferization/IR/BufferizationOps.td b/mlir/include/mlir/Dialect/Bufferization/IR/BufferizationOps.td
index 6724d4c483101..99c6f4328eb8a 100644
--- a/mlir/include/mlir/Dialect/Bufferization/IR/BufferizationOps.td
+++ b/mlir/include/mlir/Dialect/Bufferization/IR/BufferizationOps.td
@@ -96,8 +96,8 @@ def Bufferization_AllocTensorOp : Bufferization_Op<"alloc_tensor",
const BufferizationOptions &options,
BufferizationState &state);
- bool resultBufferizesToMemoryWrite(OpResult opResult,
- const AnalysisState &state);
+ bool bufferizesToMemoryWrite(OpResult opResult,
+ const AnalysisState &state);
bool bufferizesToAllocation(Value value) { return true; }
diff --git a/mlir/lib/Dialect/Bufferization/IR/BufferizableOpInterface.cpp b/mlir/lib/Dialect/Bufferization/IR/BufferizableOpInterface.cpp
index e0cf353da207f..26aa21094f193 100644
--- a/mlir/lib/Dialect/Bufferization/IR/BufferizableOpInterface.cpp
+++ b/mlir/lib/Dialect/Bufferization/IR/BufferizableOpInterface.cpp
@@ -496,7 +496,7 @@ bool AnalysisState::bufferizesToMemoryWrite(Value value) const {
auto bufferizableOp = getOptions().dynCastBufferizableOp(value);
if (!bufferizableOp)
return true;
- return bufferizableOp.resultBufferizesToMemoryWrite(opResult, *this);
+ return bufferizableOp.bufferizesToMemoryWrite(opResult, *this);
}
/// Return true if the given value is read by an op that bufferizes to a memory
@@ -882,7 +882,7 @@ bufferization::getMemRefTypeWithStaticIdentityLayout(TensorType tensorType,
// Default implementations of interface methods
//===----------------------------------------------------------------------===//
-bool bufferization::detail::defaultResultBufferizesToMemoryWrite(
+bool bufferization::detail::defaultBufferizesToMemoryWrite(
OpResult opResult, const AnalysisState &state) {
auto bufferizableOp = cast<BufferizableOpInterface>(opResult.getDefiningOp());
AliasingOpOperandList opOperands =
diff --git a/mlir/lib/Dialect/Bufferization/IR/BufferizationOps.cpp b/mlir/lib/Dialect/Bufferization/IR/BufferizationOps.cpp
index 56ff2121e4620..478d7c3a975a8 100644
--- a/mlir/lib/Dialect/Bufferization/IR/BufferizationOps.cpp
+++ b/mlir/lib/Dialect/Bufferization/IR/BufferizationOps.cpp
@@ -195,8 +195,8 @@ LogicalResult AllocTensorOp::bufferize(RewriterBase &rewriter,
return success();
}
-bool AllocTensorOp::resultBufferizesToMemoryWrite(OpResult opResult,
- const AnalysisState &state) {
+bool AllocTensorOp::bufferizesToMemoryWrite(OpResult opResult,
+ const AnalysisState &state) {
// AllocTensorOps do not write unless they have a `copy` value.
return static_cast<bool>(getCopy());
}
diff --git a/mlir/lib/Dialect/SparseTensor/Transforms/BufferizableOpInterfaceImpl.cpp b/mlir/lib/Dialect/SparseTensor/Transforms/BufferizableOpInterfaceImpl.cpp
index c65781b4804db..c0d62a7b92cd9 100644
--- a/mlir/lib/Dialect/SparseTensor/Transforms/BufferizableOpInterfaceImpl.cpp
+++ b/mlir/lib/Dialect/SparseTensor/Transforms/BufferizableOpInterfaceImpl.cpp
@@ -112,8 +112,8 @@ struct LoadOpInterface
struct NewOpInterface
: public SparseBufferizableOpInterfaceExternalModel<NewOpInterface,
sparse_tensor::NewOp> {
- bool resultBufferizesToMemoryWrite(Operation *op, OpResult opResult,
- const AnalysisState &state) const {
+ bool bufferizesToMemoryWrite(Operation *op, OpResult opResult,
+ const AnalysisState &state) const {
// NewOps allocate but do not write.
return false;
}
diff --git a/mlir/lib/Dialect/Tensor/Transforms/BufferizableOpInterfaceImpl.cpp b/mlir/lib/Dialect/Tensor/Transforms/BufferizableOpInterfaceImpl.cpp
index bce964e47a3be..605877175ff67 100644
--- a/mlir/lib/Dialect/Tensor/Transforms/BufferizableOpInterfaceImpl.cpp
+++ b/mlir/lib/Dialect/Tensor/Transforms/BufferizableOpInterfaceImpl.cpp
@@ -272,8 +272,8 @@ struct EmptyOpInterface
tensor::EmptyOp> {
bool bufferizesToAllocation(Operation *op, Value value) const { return true; }
- bool resultBufferizesToMemoryWrite(Operation *op, OpResult opResult,
- const AnalysisState &state) const {
+ bool bufferizesToMemoryWrite(Operation *op, OpResult opResult,
+ const AnalysisState &state) const {
// The returned tensor does not have specified contents.
return false;
}
More information about the Mlir-commits
mailing list