[Mlir-commits] [mlir] [mlir][dataflow] Fix LivenessAnalysis/RemoveDeadValues handling of loop induction variables (PR #161117)

[Mehdi Amini]

================
@@ -309,15 +310,29 @@ RunLivenessAnalysis::RunLivenessAnalysis(Operation *op) {
              << " has no liveness info (unreachable), mark dead";
       solver.getOrCreateState<Liveness>(result.value());
     }
+    SmallVector<Value> mustLiveValues;
+    if (auto loopOp = dyn_cast<LoopLikeOpInterface>(op)) {
----------------
joker-eph wrote:

Let's step back and start from basics: if you don't know anything about an operation (there is no interface), you still need to treat it conservatively and not modifying it right?

Why are we modifying an op here without knowing that it's OK to do?

https://github.com/llvm/llvm-project/pull/161117