[Mlir-commits] [mlir] [mlir][Vector] Fold vector.step compared to constant (PR #161615)

Andrzej WarzyƄski llvmlistbot at llvm.org
Mon Oct 6 06:54:27 PDT 2025


================

----------------
banach-space wrote:

Many tests in this file are "negative" tests. Could you use a prefix to clearly signal such cases? See https://mlir.llvm.org/getting_started/TestingGuide/#test-naming-convention

On a related note, I would avoid `check` in test function names. You can safely remove it without loosing any meaning/context ("less is more").

https://github.com/llvm/llvm-project/pull/161615


More information about the Mlir-commits mailing list