[Mlir-commits] [mlir] e543ca6 - [mlir][vector][nfc] Add comments in tests (#160106)

[llvmlistbot at llvm.org]

Author: Andrzej Warzyński
Date: 2025-10-05T17:33:02+01:00
New Revision: e543ca685791b7424fb99187507fd555ff7832d4

URL: https://github.com/llvm/llvm-project/commit/e543ca685791b7424fb99187507fd555ff7832d4
DIFF: https://github.com/llvm/llvm-project/commit/e543ca685791b7424fb99187507fd555ff7832d4.diff

LOG: [mlir][vector][nfc] Add comments in tests (#160106)

Small follow-up for https://github.com/llvm/llvm-project/pull/158528,
otherwise it's not clear what makes the updated tests "negative".

Added: 
    

Modified: 
    mlir/test/Dialect/Vector/canonicalize.mlir

Removed: 
    


################################################################################
diff  --git a/mlir/test/Dialect/Vector/canonicalize.mlir b/mlir/test/Dialect/Vector/canonicalize.mlir
index 5448976f84760..bccf5d5b77b0e 100644
--- a/mlir/test/Dialect/Vector/canonicalize.mlir
+++ b/mlir/test/Dialect/Vector/canonicalize.mlir
@@ -3377,6 +3377,9 @@ func.func @negative_from_elements_to_constant() -> vector<1x!llvm.ptr> {
 
 // -----
 
+// `foldFromElementsToConstant` does not support `ub.poison`, so it bails out.
+// Instead, other folders apply here (e.g. `rewriteFromElementsAsBroadcast`).
+
 // CHECK-LABEL: @negative_from_elements_poison
 //       CHECK:   %[[VAL:.*]] = ub.poison : vector<2xf32>
 //       CHECK:   return %[[VAL]] : vector<2xf32>
@@ -3388,6 +3391,9 @@ func.func @negative_from_elements_poison_f32() -> vector<2xf32> {
 
 // -----
 
+// `foldFromElementsToConstant` does not support `ub.poison`, so it bails out.
+// Instead, other folders apply here (e.g. `rewriteFromElementsAsBroadcast`).
+
 // CHECK-LABEL: @negative_from_elements_poison_i32
 //       CHECK:   %[[VAL:.*]] = ub.poison : vector<2xi32>
 //       CHECK:   return %[[VAL]] : vector<2xi32>
@@ -3399,6 +3405,9 @@ func.func @negative_from_elements_poison_i32() -> vector<2xi32> {
 
 // -----
 
+// `foldFromElementsToConstant` does not support `ub.poison`, so it bails out.
+// Instead, other folders apply here (e.g. `rewriteFromElementsAsBroadcast`).
+
 // CHECK-LABEL: @negative_from_elements_poison_constant_mix
 //       CHECK:   %[[POISON:.*]] = ub.poison : f32
 //       CHECK:   %[[CONST:.*]] = arith.constant 1.000000e+00 : f32