[Mlir-commits] [mlir] [MLIR] Add options to generate-runtime-verification to enable faster pass running (PR #160331)

[Mehdi Amini]

================
@@ -36,10 +44,46 @@ void GenerateRuntimeVerificationPass::runOnOperation() {
     ops.push_back(verifiableOp);
   });
 
+  // Create error message generator based on verboseLevel
----------------
joker-eph wrote:

>  I think the SSA name created by this AsmState will be stored to the op and used by the emitter later for the op. But it seems that this is not the case.

I don't follow what you mean here?

Especially because it seems to contradict what you said before:

> Similar to above - the operand names dumped in the assert/error message do seem to be some names that only exist in the middle of the application of the pass. 

> In addition, I took a look at AsmState definition. It says "The IR should not be mutated in-between invocations using this state

I need to look exactly at what kind of issues this is trying to protect against, I suspect it is a concern of state invalidation and stale pointer, which may be safe in the context of what we're doing here.

https://github.com/llvm/llvm-project/pull/160331