[Mlir-commits] [mlir] [NFC][Linalg] Introduce ConvMatchBuilder + refactor Conv matchers (PR #169704)

[Andrzej Warzyński]

================
@@ -434,6 +430,91 @@ static bool convLayoutMatches(ArrayRef<ArrayRef<AffineExpr>> mapListExpected,
                           })));
 }
 
+/// Enum of all kinds of Pooling Op's type.
+enum PoolingType {
+  NONE,
+  MAX_SIGNED,
+  MAX_UNSIGNED,
+  MIN_SIGNED,
+  MIN_UNSIGNED,
+  SUM
+};
----------------
banach-space wrote:

Why are these all in CAPS? (See https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly). And why not use `enum class` instead?

https://github.com/llvm/llvm-project/pull/169704