[Mlir-commits] [mlir] [mlir][AMDGPU] Add scaled wmma ops for gfx1250 (PR #169854)

[Muzammiluddin Syed]

================
@@ -1218,6 +1226,54 @@ def AMDGPU_ScaledMFMAOp :
   let hasCanonicalizer = 1;
 }
 
+def AMDGPU_ScaledWMMAOp
+    : AMDGPU_Op<"scaled_wmma", [AllTypesMatch<["destC", "destD"]>, Pure]>,
+      Arguments<(ins ConfinedAttr<I32Attr, [IntIsOneOf<[16, 32]>]>:$m,
+          ConfinedAttr<I32Attr, [IntIsOneOf<[16]>]>:$n,
+          ConfinedAttr<I32Attr, [IntIsOneOf<[128]>]>:$k,
+          ScaledWMMAInTypes:$sourceA, ScaledWMMAInTypes:$sourceB,
+          ScaledWMMAOutTypes:$destC, AnyTypeOf<[I32, I64]>:$scaleA,
----------------
Muzammiluddin-Syed-ECE wrote:

```suggestion
          ScaledWMMAInTypes:$sourceA,
          ScaledWMMAInTypes:$sourceB,
          ScaledWMMAOutTypes:$destC,
          AnyTypeOf<[I32, I64]>:$scaleA,
```
nit: it's hard to read (I'm used to seeing one line per argument).

https://github.com/llvm/llvm-project/pull/169854