[Mlir-commits] [mlir] [mlir][Transforms] Fix crash in `-remove-dead-values` on private functions (PR #169269)

[Mehdi Amini]

joker-eph wrote:

> We cannot just remove that op because the basic block would loose its terminator. Maybe we could insert an unconditional cf.br op. (Difficult because we match for BranchOpInterface and not specific ops.) Or we could insert a ub.poison for the condition.

Seems to me that this is a case where we would insert a "unreachable" terminator instead?

https://github.com/llvm/llvm-project/pull/169269