[Mlir-commits] [mlir] [mlir][amdgpu] Add amdgpu.make_dma_descriptor (PR #169407)

[Krzysztof Drewniak]

================
@@ -701,6 +739,20 @@ LogicalResult TransposeLoadOp::verify() {
   return success();
 }
 
+//===----------------------------------------------------------------------===//
+// MakeDmaDescriptorOp
+//===----------------------------------------------------------------------===//
+
+LogicalResult MakeDmaDescriptorOp::verify() {
+  if (getGlobalStaticStrides()->empty()) {
+    return emitOpError("strides must not be empty.");
+  }
+  if (getGlobalStaticStrides()->back() != 1) {
+    return emitOpError("strides for the innermost dimension must be 1.");
+  }
+  return success();
----------------
krzysz00 wrote:

Missing validation conditions: Number of strides == number of sizes == number of offsets, and the global and LDS tiles have the same dimensions 

https://github.com/llvm/llvm-project/pull/169407