[Mlir-commits] [mlir] [mlir][linalg] Restrict fill initial value type to output element type (PR #169567)

[Andrzej Warzyński]

https://github.com/banach-space approved this pull request.

We should remove all implicit casting. 

For example, the very fact it's hard-coded to _signed_ is, IMO, problematic. Why not _unsigned_? And yes, sometimes you may required _unsigned_ extension:
* https://discourse.llvm.org/t/numerical-casting-in-linalg-conv-2d/68643

Even for contractions, the current approach is not sufficient (we ought to differentiate between the compute and the result types).

Anyway 😅 This changes makes a lot of sense to me , thanks! It would be great to re-start the discussion on these implicit castings in general, but I appreciate that's out-of-scope.

https://github.com/llvm/llvm-project/pull/169567