[Mlir-commits] [mlir] [Linalg] Add *Conv2D* matchers (PR #168362)

[Han-Chung Wang]

hanhanW wrote:

> Hi @hanhanW !
> 
> That was such a nice suggestion. I've addressed your comments!
> 
> I was trying to also see if there's a way for us to simply just initialize with "(N, H, W, C, h, w)" string using the `ConvMatchBuilder` and then we simply just pass the string versions of the indexing maps directly - so this way the caller doesn't need to initialize so many dims locally. But it turned out to be a bit more involved so I just stuck with the current suggestion. :D
> 
> Can you please take a look now ?

I'll be out for a week. QQ: can we split it to two PRs? One for introducing `ConvMatchBuilder` and use it for existing patterns, and the other (which can be this one) is for 2D convs that we adding in this PR?

https://github.com/llvm/llvm-project/pull/168362