[Mlir-commits] [mlir] [mlir][Transforms] Fix crash in `-remove-dead-values` on private functions (PR #169269)

[Mehdi Amini]

================
@@ -118,6 +118,17 @@ func.func @main(%arg0 : i32) {
 
 // -----
 
+// CHECK-LABEL: func.func private @clean_func_op_remove_side_effecting_op() {
+// CHECK-NEXT:    return
+// CHECK-NEXT:  }
+func.func private @clean_func_op_remove_side_effecting_op(%arg0: i32) -> (i32) {
+  // vector.print has a side effect but the op is dead.
+  vector.print %arg0 : i32
+  return %arg0 : i32
+}
----------------
joker-eph wrote:

> My reasoning is: If the liveness analysis determined that an SSA value is dead, so must be all users of that SSA values. If there were live users, the analysis would not have marked the SSA value as "dead". Is there a flaw in my conclusion?

Seems fair, can you improve inline documentation in the code maybe? Thanks!

https://github.com/llvm/llvm-project/pull/169269