[Mlir-commits] [mlir] [MLIR][SCF] Sink scf.if from scf.while before region into after region. (PR #165216)

[Mehdi Amini]

================

----------------
joker-eph wrote:

> The reason is to avoid creating a new scf.while, which would inflate its result values

I don't quite see the problem with this though, seems like the kind of usual transformations we do.

>  and to avoid additional def-use chain analysis that would increase compile-time overhead.

Do you have examples of compile-time issue? I'd rather be specific and be able to measure the issue here.

> We can treat this as an initial version and improve it gradually later, right?

If you rather go this route, then before merging this I think I'd like to see a chain of stacked/dependent PRs showing the end results with the gradual steps to get there.


https://github.com/llvm/llvm-project/pull/165216