[Mlir-commits] [mlir] [mlir][Transforms] Fix crash in `-remove-dead-values` on private functions (PR #169269)

[Mehdi Amini]

================
@@ -118,6 +118,17 @@ func.func @main(%arg0 : i32) {
 
 // -----
 
+// CHECK-LABEL: func.func private @clean_func_op_remove_side_effecting_op() {
+// CHECK-NEXT:    return
+// CHECK-NEXT:  }
+func.func private @clean_func_op_remove_side_effecting_op(%arg0: i32) -> (i32) {
+  // vector.print has a side effect but the op is dead.
+  vector.print %arg0 : i32
+  return %arg0 : i32
+}
----------------
joker-eph wrote:

this logic that you quote makes somehow sense to me: based on liveness of the results we figure that an op is dead.
Doing the same based on operands is less clear to me.

By the way, I wonder if you're trying to fix what this patch was aiming to fix as well: https://github.com/llvm/llvm-project/pull/162038
(I don't know why it was closed last week)

https://github.com/llvm/llvm-project/pull/169269