[Mlir-commits] [mlir] [mlir][Transforms] Fix crash in `-remove-dead-values` on private functions (PR #169269)

[Oleksandr Alex Zinenko]

https://github.com/ftynse requested changes to this pull request.

Indeed, I think we shouldn't just remove side-effecting operations, this changes the observable behavior of the program. Maybe in some separate `-remove-otherwise-dead-side-effecting-operations-i'm-sure-what-i'm-doing` pass if really needed. Prints may be innocuous, but this could also remove `cf.assert %false` or a write to invalid memory location, rendering an incorrect program correct.

https://github.com/llvm/llvm-project/pull/169269