[Mlir-commits] [mlir] [vector][mlir] Canonicalize to shape_cast where possible (PR #140583)

[Andrzej Warzyński]

banach-space wrote:

Thank you for the detailed discussion, @dcaballe - that was very helpful in clarifying the underlying issues.

> I suggest that we continue focusing on the technical aspects of the different IR forms. Could we continue this exercise?

Agreed.

That’s one concrete example (*). @MaheshRavishankar, could you help us identify other _specific_ cases so that we can better scope or constrain this change?

All in all, given the nuances discussed, I don’t see a specific blocker preventing this from being merged - or is there?

> This does not seem like a great setup.

I think we may have to agree to disagree here. That said, as `Vector` maintainers, we’re committed to supporting all `Vector` users. If this change ends up causing issues for you, we’ll work with you to address them.

-Andrzej

(*) A transpose operation to a shape cast when multiple unit dimensions are transposed.

https://github.com/llvm/llvm-project/pull/140583