[Mlir-commits] [mlir] [mlir][llvm] Handle debug record import edge cases (PR #168774)

[Tobias Gysi]

================
@@ -3203,26 +3228,36 @@ LogicalResult ModuleImport::processDebugRecord(llvm::DbgRecord &debugRecord,
     return failure();
   };
 
+  // Drop debug records with an argument list.
+  // TODO: Support this case.
+  if (debugRecord.hasArgList())
+    return emitUnsupportedDebugRecordWarning(debugRecord, loc);
+
+  // Drop kill location debug records with a null address operand, which cannot
+  // be converted to poison as the type cannot be reconstructed.
+  // TODO: Support this case.
+  if (!debugRecord.getAddress())
+    return emitUnsupportedDebugRecordWarning(debugRecord, loc);
----------------
gysit wrote:

my understanding is that a non SSA value is either an argument list or a kill location (I may have missed some other exceptions though). I clarify the comment to state that we need an SSA value for the conversion to MLIR.

https://github.com/llvm/llvm-project/pull/168774