[Mlir-commits] [mlir] [mlir] Fix GCC compilation warning in TuneExtensionOps.cpp (PR #168850)

[llvmlistbot at llvm.org]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-mlir

Author: David Spickett (DavidSpickett)

<details>
<summary>Changes</summary>

Building with GCC produces:
```
<...>/TuneExtensionOps.cpp:180:26: warning: comparison of unsigned expression in ‘< 0’ is always false [-Wtype-limits]
  180 |   if (*selectedRegionIdx < 0 || *selectedRegionIdx >= getNumRegions())
      |       ~~~~~~~~~~~~~~~~~~~^~~
<...>/TuneExtensionOps.cpp: In member function ‘llvm::LogicalResult mlir::transform::tune::AlternativesOp::verify()’:
/home/david.spickett/llvm-project/mlir/lib/Dialect/Transform/TuneExtension/TuneExtensionOps.cpp:236:19: warning: comparison of unsigned expression in ‘< 0’ is always false [-Wtype-limits]
  236 |     if (regionIdx < 0 || regionIdx >= getNumRegions())
      |         ~~~~~~~~~~^~~
```

Both of these are a size_t, which is always unsigned.

---
Full diff: https://github.com/llvm/llvm-project/pull/168850.diff


1 Files Affected:

- (modified) mlir/lib/Dialect/Transform/TuneExtension/TuneExtensionOps.cpp (+2-2) 


``````````diff
diff --git a/mlir/lib/Dialect/Transform/TuneExtension/TuneExtensionOps.cpp b/mlir/lib/Dialect/Transform/TuneExtension/TuneExtensionOps.cpp
index f727118f3f9a0..78663827a2abd 100644
--- a/mlir/lib/Dialect/Transform/TuneExtension/TuneExtensionOps.cpp
+++ b/mlir/lib/Dialect/Transform/TuneExtension/TuneExtensionOps.cpp
@@ -177,7 +177,7 @@ transform::tune::AlternativesOp::apply(transform::TransformRewriter &rewriter,
                                  << " is only resolved through providing a "
                                     "`selected_region` attr/param";
 
-  if (*selectedRegionIdx < 0 || *selectedRegionIdx >= getNumRegions())
+  if (*selectedRegionIdx >= getNumRegions())
     return emitDefiniteFailure()
            << "'selected_region' attribute/param specifies region at index "
            << *selectedRegionIdx << " while op has only " << getNumRegions()
@@ -233,7 +233,7 @@ LogicalResult transform::tune::AlternativesOp::verify() {
 
   if (auto selectedRegionAttr = getSelectedRegionAttr()) {
     size_t regionIdx = selectedRegionAttr->getSExtValue();
-    if (regionIdx < 0 || regionIdx >= getNumRegions())
+    if (regionIdx >= getNumRegions())
       return emitOpError()
              << "'selected_region' attribute specifies region at index "
              << regionIdx << " while op has only " << getNumRegions()

``````````

</details>


https://github.com/llvm/llvm-project/pull/168850