[Mlir-commits] [mlir] Revert "[mlir][Pass] Fix crash when applying a pass to an optional interface" (PR #168847)

[llvmlistbot at llvm.org]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-mlir-core

Author: Matthias Springer (matthias-springer)

<details>
<summary>Changes</summary>

Reverts llvm/llvm-project#<!-- -->168499

---
Full diff: https://github.com/llvm/llvm-project/pull/168847.diff


5 Files Affected:

- (modified) mlir/include/mlir/Pass/Pass.h (-8) 
- (modified) mlir/lib/Pass/Pass.cpp (+3-3) 
- (modified) mlir/test/Dialect/Transform/test-pass-application.mlir (+1-1) 
- (removed) mlir/test/Pass/invalid-unsupported-operation.mlir (-10) 
- (modified) mlir/test/Pass/pipeline-invalid.mlir (+1-1) 


``````````diff
diff --git a/mlir/include/mlir/Pass/Pass.h b/mlir/include/mlir/Pass/Pass.h
index 448a688243491..16893c6db87b1 100644
--- a/mlir/include/mlir/Pass/Pass.h
+++ b/mlir/include/mlir/Pass/Pass.h
@@ -193,13 +193,6 @@ class Pass {
   /// This is useful for generic operation passes to add restrictions on the
   /// operations they operate on.
   virtual bool canScheduleOn(RegisteredOperationName opName) const = 0;
-  virtual bool canScheduleOn(Operation *op) const {
-    std::optional<RegisteredOperationName> registeredInfo =
-        op->getName().getRegisteredInfo();
-    if (!registeredInfo)
-      return false;
-    return canScheduleOn(*registeredInfo);
-  }
 
   /// Schedule an arbitrary pass pipeline on the provided operation.
   /// This can be invoke any time in a pass to dynamic schedule more passes.
@@ -443,7 +436,6 @@ class InterfacePass : public OperationPass<> {
   /// Indicate if the current pass can be scheduled on the given operation type.
   /// For an InterfacePass, this checks if the operation implements the given
   /// interface.
-  bool canScheduleOn(Operation *op) const final { return isa<InterfaceT>(op); }
   bool canScheduleOn(RegisteredOperationName opName) const final {
     return opName.hasInterface<InterfaceT>();
   }
diff --git a/mlir/lib/Pass/Pass.cpp b/mlir/lib/Pass/Pass.cpp
index 75f882606e0ab..521c7c6be17b6 100644
--- a/mlir/lib/Pass/Pass.cpp
+++ b/mlir/lib/Pass/Pass.cpp
@@ -559,9 +559,9 @@ LogicalResult OpToOpPassAdaptor::run(Pass *pass, Operation *op,
     return op->emitOpError() << "trying to schedule a pass on an operation not "
                                 "marked as 'IsolatedFromAbove'";
   }
-  if (!pass->canScheduleOn(op)) {
-    return op->emitOpError() << "trying to schedule pass '" << pass->getName()
-                             << "' on an unsupported operation";
+  if (!pass->canScheduleOn(*op->getName().getRegisteredInfo())) {
+    return op->emitOpError()
+           << "trying to schedule a pass on an unsupported operation";
   }
 
   // Initialize the pass state with a callback for the pass to dynamically
diff --git a/mlir/test/Dialect/Transform/test-pass-application.mlir b/mlir/test/Dialect/Transform/test-pass-application.mlir
index 4806daf7ce73f..ce8f69c58701d 100644
--- a/mlir/test/Dialect/Transform/test-pass-application.mlir
+++ b/mlir/test/Dialect/Transform/test-pass-application.mlir
@@ -386,7 +386,7 @@ module attributes {transform.with_named_sequence} {
 // -----
 
 module attributes {transform.with_named_sequence} {
-  // expected-error @below {{trying to schedule pass 'DuplicateFunctionEliminationPass' on an unsupported operation}}
+  // expected-error @below {{trying to schedule a pass on an unsupported operation}}
   // expected-note @below {{target op}}
   func.func @invalid_target_op_type() {
     return
diff --git a/mlir/test/Pass/invalid-unsupported-operation.mlir b/mlir/test/Pass/invalid-unsupported-operation.mlir
deleted file mode 100644
index 0ff49448c1daf..0000000000000
--- a/mlir/test/Pass/invalid-unsupported-operation.mlir
+++ /dev/null
@@ -1,10 +0,0 @@
-// RUN: mlir-opt %s -test-print-liveness -split-input-file -verify-diagnostics
-
-// Unnamed modules do not implement SymbolOpInterface.
-// expected-error @+1 {{trying to schedule pass '(anonymous namespace)::TestLivenessPass' on an unsupported operation}}
-module {}
-
-// -----
-
-// Named modules implement SymbolOpInterface.
-module @named_module {}
diff --git a/mlir/test/Pass/pipeline-invalid.mlir b/mlir/test/Pass/pipeline-invalid.mlir
index 4116e127a24a6..948a13384bc75 100644
--- a/mlir/test/Pass/pipeline-invalid.mlir
+++ b/mlir/test/Pass/pipeline-invalid.mlir
@@ -15,5 +15,5 @@ arith.constant 0
 
 // -----
 
-// expected-error at below {{trying to schedule pass '(anonymous namespace)::TestFunctionPass' on an unsupported operation}}
+// expected-error at below {{trying to schedule a pass on an unsupported operation}}
 module {}

``````````

</details>


https://github.com/llvm/llvm-project/pull/168847