[Mlir-commits] [mlir] [mlir][linalg] Reject unsigned pooling on non-integer element types (PR #166070)

[Andrzej Warzyński]

================
@@ -579,13 +579,23 @@ class RegionBuilderHelper {
       return arith::MinSIOp::create(builder, arg0.getLoc(), arg0, arg1);
     case BinaryFn::max_unsigned:
       assert(!allComplex);
-      if (allFloatingPoint)
-        return arith::MaximumFOp::create(builder, arg0.getLoc(), arg0, arg1);
+      if (!allInteger || allBool) {
+        if (emitError) {
+          emitError() << "unsupported operation: unsigned max not on uint";
+          return nullptr;
+        }
+        llvm_unreachable("unsupported operation: unsigned max not on uint");
+      }
----------------
banach-space wrote:

I'm not really familiar with OPDSL, but in ideal world we should be able to write verification tests and add them in  https://github.com/llvm/llvm-project/blob/main/mlir/test/Dialect/Linalg/invalid.mlir - could you try @Men-cotton ?

https://github.com/llvm/llvm-project/pull/166070