[Mlir-commits] [mlir] [MLIR][Vector] Add unroll pattern for vector.shape_cast (PR #167738)

[Andrzej Warzyński]

================
@@ -1003,6 +1003,194 @@ struct UnrollFromElements : OpRewritePattern<vector::FromElementsOp> {
   vector::UnrollVectorOptions options;
 };
 
+/// Checks whether extractShape is contiguous in shape.
+/// For extractShape to be contiguous in shape:
+/// 1) The inner dimensions of extractShape and shape must match exactly.
----------------
banach-space wrote:

How does one define `the inner dimensions`? _How many_ of the inner dimensions would that be? I think that you can disambiguate by rewriting as `All but the leading dimension of extractShape and shape must match exactly`. WDYT?

https://github.com/llvm/llvm-project/pull/167738