[Mlir-commits] [mlir] [mlir] Make remove-dead-values remove block and successorOperands before delete ops (PR #166766)

[Matthias Springer]

================
@@ -742,7 +742,49 @@ static void processBranchOp(BranchOpInterface branchOp, RunLivenessAnalysis &la,
 static void cleanUpDeadVals(RDVFinalCleanupList &list) {
   LDBG() << "Starting cleanup of dead values...";
 
-  // 1. Operations
+  // 1. Blocks, We must remove the block arguments and successor operands before
----------------
matthias-springer wrote:

So this is a case of "delete stuff inside the operation before the operation itself"? Do we also guarantee that when erasing operations?

https://github.com/llvm/llvm-project/pull/166766