[Mlir-commits] [mlir] [MLIR][NVVM] Remove constexpr qualifier from getNVVMCtaGroupKind (PR #168552)

[llvmlistbot at llvm.org]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-mlir-llvm

@llvm/pr-subscribers-mlir

Author: Pradeep Kumar (schwarzschild-radius)

<details>
<summary>Changes</summary>

This commit removes constexpr qualifier from getNVVMCtaGroupKind function as llvm_unreachable cannot be used in a constexpr context. The build failures came up during post-merge CI

---
Full diff: https://github.com/llvm/llvm-project/pull/168552.diff


1 Files Affected:

- (modified) mlir/lib/Dialect/LLVMIR/IR/NVVMDialect.cpp (+1-1) 


``````````diff
diff --git a/mlir/lib/Dialect/LLVMIR/IR/NVVMDialect.cpp b/mlir/lib/Dialect/LLVMIR/IR/NVVMDialect.cpp
index 369305b40c689..0e620737109b8 100644
--- a/mlir/lib/Dialect/LLVMIR/IR/NVVMDialect.cpp
+++ b/mlir/lib/Dialect/LLVMIR/IR/NVVMDialect.cpp
@@ -62,7 +62,7 @@ static bool isPtrInSharedCTASpace(mlir::Value ptr) {
 }
 
 // Helper method to convert CtaGroupKind in NVVM Dialect to CtaGroupKind in LLVM
-static constexpr llvm::nvvm::CTAGroupKind
+static llvm::nvvm::CTAGroupKind
 getNVVMCtaGroupKind(NVVM::CTAGroupKind ctaGroup) {
   switch (ctaGroup) {
   case NVVM::CTAGroupKind::CTA_1:

``````````

</details>


https://github.com/llvm/llvm-project/pull/168552