[Mlir-commits] [mlir] [mlir][spirv] Add support for TOSA Extended Instruction Set (001000.1) (PR #168519)

[Igor Wodiany]

IgWod-IMG wrote:

I've just skimmed through the changes, and I'll try to review it in more details in the coming days, but my first thought: is it possible to push some more verification into ODS. Immediately I see a lot of checks with the pattern:

```c
if (xxx.hasRank() && yyy.getRank() != N)
```

Maybe a mix of existing and custom predicates could deal with that nicely? The image operations may give you some inspiration for that: https://github.com/llvm/llvm-project/blob/main/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVImageOps.td

https://github.com/llvm/llvm-project/pull/168519