[Mlir-commits] [mlir] [MLIR][SCF] Sink scf.if from scf.while before region into after region. (PR #165216)

[Ming Yan]

NexMing wrote:

> Oh, I see this was moved back into canonicalization. So I was mistaken on the state of the change.
> 
> Really this is bad practice! I urge you to not add it as a canonicalization, but I dont have the heart to block this change, even though in my book this is following bad practices.

I’ve already moved it out of canonicalization; now it’s in UpliftWhileToForPatterns.

I’m not opposed to moving it out of canonicalization, but I believe the reason for doing so is that this transformation is complex and expensive, which leads to instability, rather than it being unsuitable for canonicalization. Once this optimization becomes sufficiently stable, could we move it back into the canonicalization stage?

https://github.com/llvm/llvm-project/pull/165216