[Mlir-commits] [mlir] [mlir] Use LDBG to replace LLVM_DEBUG (NFC) (PR #166733)
lonely eagle
llvmlistbot at llvm.org
Thu Nov 6 01:20:59 PST 2025
https://github.com/linuxlonelyeagle updated https://github.com/llvm/llvm-project/pull/166733
>From b6d15a945547609eecfa6c2945aa61e3e0356a02 Mon Sep 17 00:00:00 2001
From: linuxlonelyeagle <2020382038 at qq.com>
Date: Thu, 6 Nov 2025 09:14:01 +0000
Subject: [PATCH 1/2] use LDBG() to replace LLVM_DEBUG.
---
.../lib/Interfaces/ValueBoundsOpInterface.cpp | 42 ++++++++-----------
1 file changed, 18 insertions(+), 24 deletions(-)
diff --git a/mlir/lib/Interfaces/ValueBoundsOpInterface.cpp b/mlir/lib/Interfaces/ValueBoundsOpInterface.cpp
index d2bafb701046e..9882e8b6318a8 100644
--- a/mlir/lib/Interfaces/ValueBoundsOpInterface.cpp
+++ b/mlir/lib/Interfaces/ValueBoundsOpInterface.cpp
@@ -16,6 +16,7 @@
#include "mlir/Interfaces/ViewLikeInterface.h"
#include "llvm/ADT/APSInt.h"
#include "llvm/Support/Debug.h"
+#include "llvm/Support/DebugLog.h"
#define DEBUG_TYPE "value-bounds-op-interface"
@@ -195,7 +196,7 @@ void ValueBoundsConstraintSet::addBound(BoundType type, int64_t pos,
// Even without this bound, there may be enough information in the
// constraint system to compute the requested bound. In case this bound is
// actually needed, `computeBound` will return `failure`.
- LLVM_DEBUG(llvm::dbgs() << "Failed to add bound: " << expr << "\n");
+ LDBG() << "Failed to add bound: " << expr << "\n";
}
}
@@ -271,11 +272,9 @@ int64_t ValueBoundsConstraintSet::insert(Value value,
assert(!valueDimToPosition.contains(valueDim) && "already mapped");
int64_t pos = isSymbol ? cstr.appendVar(VarKind::Symbol)
: cstr.appendVar(VarKind::SetDim);
- LLVM_DEBUG(llvm::dbgs() << "Inserting constraint set column " << pos
- << " for: " << value
- << " (dim: " << dim.value_or(kIndexValue)
- << ", owner: " << getOwnerOfValue(value)->getName()
- << ")\n");
+ LDBG() << "Inserting constraint set column " << pos << " for: " << value
+ << " (dim: " << dim.value_or(kIndexValue)
+ << ", owner: " << getOwnerOfValue(value)->getName() << ")\n";
positionToValueDim.insert(positionToValueDim.begin() + pos, valueDim);
// Update reverse mapping.
for (int64_t i = pos, e = positionToValueDim.size(); i < e; ++i)
@@ -283,8 +282,8 @@ int64_t ValueBoundsConstraintSet::insert(Value value,
valueDimToPosition[*positionToValueDim[i]] = i;
if (addToWorklist) {
- LLVM_DEBUG(llvm::dbgs() << "Push to worklist: " << value
- << " (dim: " << dim.value_or(kIndexValue) << ")\n");
+ LDBG() << "Push to worklist: " << value
+ << " (dim: " << dim.value_or(kIndexValue) << ")\n";
worklist.push(pos);
}
@@ -294,8 +293,7 @@ int64_t ValueBoundsConstraintSet::insert(Value value,
int64_t ValueBoundsConstraintSet::insert(bool isSymbol) {
int64_t pos = isSymbol ? cstr.appendVar(VarKind::Symbol)
: cstr.appendVar(VarKind::SetDim);
- LLVM_DEBUG(llvm::dbgs() << "Inserting anonymous constraint set column " << pos
- << "\n");
+ LDBG() << "Inserting anonymous constraint set column " << pos << "\n";
positionToValueDim.insert(positionToValueDim.begin() + pos, std::nullopt);
// Update reverse mapping.
for (int64_t i = pos, e = positionToValueDim.size(); i < e; ++i)
@@ -339,10 +337,9 @@ int64_t ValueBoundsConstraintSet::getPos(Value value,
cast<BlockArgument>(value).getOwner()->isEntryBlock()) &&
"unstructured control flow is not supported");
#endif // NDEBUG
- LLVM_DEBUG(llvm::dbgs() << "Getting pos for: " << value
- << " (dim: " << dim.value_or(kIndexValue)
- << ", owner: " << getOwnerOfValue(value)->getName()
- << ")\n");
+ LDBG() << "Getting pos for: " << value
+ << " (dim: " << dim.value_or(kIndexValue)
+ << ", owner: " << getOwnerOfValue(value)->getName() << ")\n";
auto it =
valueDimToPosition.find(std::make_pair(value, dim.value_or(kIndexValue)));
assert(it != valueDimToPosition.end() && "expected mapped entry");
@@ -364,7 +361,7 @@ bool ValueBoundsConstraintSet::isMapped(Value value,
}
void ValueBoundsConstraintSet::processWorklist() {
- LLVM_DEBUG(llvm::dbgs() << "Processing value bounds worklist...\n");
+ LDBG() << "Processing value bounds worklist...\n";
while (!worklist.empty()) {
int64_t pos = worklist.front();
worklist.pop();
@@ -386,8 +383,8 @@ void ValueBoundsConstraintSet::processWorklist() {
// Do not process any further if the stop condition is met.
auto maybeDim = dim == kIndexValue ? std::nullopt : std::make_optional(dim);
if (stopCondition(value, maybeDim, *this)) {
- LLVM_DEBUG(llvm::dbgs() << "Stop condition met for: " << value
- << " (dim: " << maybeDim << ")\n");
+ LDBG() << "Stop condition met for: " << value << " (dim: " << maybeDim
+ << ")\n";
continue;
}
@@ -395,9 +392,8 @@ void ValueBoundsConstraintSet::processWorklist() {
// the worklist.
auto valueBoundsOp =
dyn_cast<ValueBoundsOpInterface>(getOwnerOfValue(value));
- LLVM_DEBUG(llvm::dbgs()
- << "Query value bounds for: " << value
- << " (owner: " << getOwnerOfValue(value)->getName() << ")\n");
+ LDBG() << "Query value bounds for: " << value
+ << " (owner: " << getOwnerOfValue(value)->getName() << ")\n";
if (valueBoundsOp) {
if (dim == kIndexValue) {
valueBoundsOp.populateBoundsForIndexValue(value, *this);
@@ -406,7 +402,7 @@ void ValueBoundsConstraintSet::processWorklist() {
}
continue;
}
- LLVM_DEBUG(llvm::dbgs() << "--> ValueBoundsOpInterface not implemented\n");
+ LDBG() << "--> ValueBoundsOpInterface not implemented\n";
// If the op does not implement `ValueBoundsOpInterface`, check if it
// implements the `DestinationStyleOpInterface`. OpResults of such ops are
@@ -705,9 +701,7 @@ bool ValueBoundsConstraintSet::comparePos(int64_t lhsPos,
// We cannot prove anything if the constraint set is already empty.
if (cstr.isEmpty()) {
- LLVM_DEBUG(
- llvm::dbgs()
- << "cannot compare value/dims: constraint system is already empty");
+ LDBG() << "cannot compare value/dims: constraint system is already empty";
return false;
}
>From 0920e18cb255ef368895d08910ea87f58bba3098 Mon Sep 17 00:00:00 2001
From: lonely eagle <2020382038 at qq.com>
Date: Thu, 6 Nov 2025 17:20:51 +0800
Subject: [PATCH 2/2] Update mlir/lib/Interfaces/ValueBoundsOpInterface.cpp
Co-authored-by: Mehdi Amini <joker.eph at gmail.com>
---
mlir/lib/Interfaces/ValueBoundsOpInterface.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mlir/lib/Interfaces/ValueBoundsOpInterface.cpp b/mlir/lib/Interfaces/ValueBoundsOpInterface.cpp
index 9882e8b6318a8..625c622d9385d 100644
--- a/mlir/lib/Interfaces/ValueBoundsOpInterface.cpp
+++ b/mlir/lib/Interfaces/ValueBoundsOpInterface.cpp
@@ -274,7 +274,7 @@ int64_t ValueBoundsConstraintSet::insert(Value value,
: cstr.appendVar(VarKind::SetDim);
LDBG() << "Inserting constraint set column " << pos << " for: " << value
<< " (dim: " << dim.value_or(kIndexValue)
- << ", owner: " << getOwnerOfValue(value)->getName() << ")\n";
+ << ", owner: " << getOwnerOfValue(value)->getName() << ")";
positionToValueDim.insert(positionToValueDim.begin() + pos, valueDim);
// Update reverse mapping.
for (int64_t i = pos, e = positionToValueDim.size(); i < e; ++i)
More information about the Mlir-commits
mailing list