[Mlir-commits] [mlir] [MLIR][SCF] Sink scf.if from scf.while before region into after region. (PR #165216)

[llvmlistbot at llvm.org]

MaheshRavishankar wrote:

> > The onus is to prove that this is canonical.
> 
> Sorry but at some point the onus is on you to come up with principled arguments, otherwise I can't really take your objections seriously. Canonicalization can't be defined as "whatever Mahesh think is tasteful".

So please tell me what are the principles arguments for what should be a canonicalization. I think if you can enunciate that well, then we can discuss it better. It is not about my taste. This pattern is doing major code movement. Please explain to me the framework for canonicalization that justifies doing code movement this way.  I have provided an actual concrete reason why this shouldnt be a canonicalization in my opinion (not a matter of taste). Now can you provide a counter argument as to why this should be a canonicalization. 

Anyway, I think this is not on the author of this change. The change as is fine and well structured in my book.

https://github.com/llvm/llvm-project/pull/165216