[Mlir-commits] [mlir] [mlir] Expose output strategies of TimingManager (PR #166548)
Mehdi Amini
llvmlistbot at llvm.org
Wed Nov 5 09:29:55 PST 2025
================
@@ -473,6 +473,13 @@ void registerDefaultTimingManagerCLOptions();
/// 'registerDefaultTimingManagerOptions' to a `DefaultTimingManager`.
void applyDefaultTimingManagerCLOptions(DefaultTimingManager &tm);
+/// Return a default output strategy for the specified format. This function can
+/// be used in combination with DefaultTimingManager::setOutput() to use
+/// MLIR-provided output format.
+std::unique_ptr<OutputStrategy>
+createDefaultOutputStrategy(DefaultTimingManager::OutputFormat fmt,
+ raw_ostream &os);
----------------
joker-eph wrote:
```suggestion
/// Create an output strategy for the specified format, to be passed to
/// DefaultTimingManager::setOutput().
std::unique_ptr<OutputStrategy>
createOutputStrategy(DefaultTimingManager::OutputFormat fmt,
raw_ostream &os);
```
We have another issue here which is one of namespace: most names in this header are too generic to be in the `mlir` namespace, we should move all this into a `mlir::timing` namespace instead. If you're up to it feel free to send a follow-up PR.
https://github.com/llvm/llvm-project/pull/166548
More information about the Mlir-commits
mailing list