[Mlir-commits] [mlir] [mlir][linalg] Extend `FuseElementwiseOps` pattern to work with named ops (PR #144922)

[llvmlistbot at llvm.org]

srcarroll wrote:

>There are many users of this functionality, all using this for elementwise operations. There is not much code duplication. The implementation is common, just a separate entry point without causing all downstream users to HAVE to update the controlFn. It would be good to not break the world.

Having to change user code due to upstream changes is just how using open source code works.  That's not a good reason to avoid useful changes in upstream.  I don't consider this "breaking the world", and that's a pretty alarmist response that isn't helpful code review.  And by the way I have to make non-trivial changes all the time when updating upstream, and I'm the only compiler engineer in my company.  So I have no sympathy for other users having to change code, especially those from big companies that have plenty of engineering resources.

If there's a specific concern, then please elaborate. Don't just expect the worst and guess that things will break.



https://github.com/llvm/llvm-project/pull/144922