[Mlir-commits] [mlir] [mlir-tblgen] Only create body for unpruned create (PR #166019)
Maksim Levental
llvmlistbot at llvm.org
Sat Nov 1 14:18:33 PDT 2025
================
@@ -2632,11 +2632,13 @@ void OpEmitter::genInlineCreateBody(
interleaveComma(nonBuilderStateArgsList, nonBuilderStateArgsOS);
nonBuilderStateArgs = ", " + nonBuilderStateArgs;
}
- cWithLoc->body() << llvm::formatv(inlineCreateBody, locParamName,
- nonBuilderStateArgs,
- opClass.getClassName());
- cImplicitLoc->body() << llvm::formatv(inlineCreateBodyImplicitLoc,
- nonBuilderStateArgs);
+ if (cWithLoc)
+ cWithLoc->body() << llvm::formatv(inlineCreateBody, locParamName,
+ nonBuilderStateArgs,
+ opClass.getClassName());
+ if (cImplicitLoc)
+ cImplicitLoc->body() << llvm::formatv(inlineCreateBodyImplicitLoc,
+ nonBuilderStateArgs);
----------------
makslevental wrote:
ah it calls
```c++
/// Add a new method if it is not made redundant by any existing methods and
/// prune and existing methods made redundant.
Method *addMethodAndPrune(Method &&newMethod);
```
gotcha
https://github.com/llvm/llvm-project/pull/166019
More information about the Mlir-commits
mailing list