[Mlir-commits] [mlir] ab77a70 - Fixed wrong check OperationEquivalenceTest.HashWorksWithFlags (#142210)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Fri May 30 18:14:31 PDT 2025
Author: Aviad Cohen
Date: 2025-05-30T18:14:28-07:00
New Revision: ab77a70a7441f52150694bddadcabd11f8d61533
URL: https://github.com/llvm/llvm-project/commit/ab77a70a7441f52150694bddadcabd11f8d61533
DIFF: https://github.com/llvm/llvm-project/commit/ab77a70a7441f52150694bddadcabd11f8d61533.diff
LOG: Fixed wrong check OperationEquivalenceTest.HashWorksWithFlags (#142210)
The check was meant to check `IgnoreProperties` works as expected but
operated on the wrong operation.
Co-authored-by: Aviad Cohen <aviad.cohen2 at mobileye.com>
Added:
Modified:
mlir/unittests/IR/OperationSupportTest.cpp
Removed:
################################################################################
diff --git a/mlir/unittests/IR/OperationSupportTest.cpp b/mlir/unittests/IR/OperationSupportTest.cpp
index b18512817969e..18ee9d71cb9fc 100644
--- a/mlir/unittests/IR/OperationSupportTest.cpp
+++ b/mlir/unittests/IR/OperationSupportTest.cpp
@@ -350,10 +350,10 @@ TEST(OperationEquivalenceTest, HashWorksWithFlags) {
auto req2 = b.getI32IntegerAttr(60);
Operation *opWithProperty2 = b.create<test::OpAttrMatch1>(
b.getUnknownLoc(), req2, nullptr, nullptr, req2);
- EXPECT_NE(getHash(op1, OperationEquivalence::None),
- getHash(op2, OperationEquivalence::None));
EXPECT_EQ(getHash(opWithProperty1, OperationEquivalence::IgnoreProperties),
getHash(opWithProperty2, OperationEquivalence::IgnoreProperties));
+ EXPECT_NE(getHash(opWithProperty1, OperationEquivalence::None),
+ getHash(opWithProperty2, OperationEquivalence::None));
opWithProperty1->destroy();
opWithProperty2->destroy();
}
More information about the Mlir-commits
mailing list