[Mlir-commits] [mlir] [mlir][math] Fix intrinsic conversions to LLVM for 0D-vector types (PR #141020)

Artem Gindinson llvmlistbot at llvm.org
Fri May 30 10:24:57 PDT 2025


AGindinson wrote:

> I am OK with these changes, but still don't understand the selection process for the Ops to update:
> 
> > Employ this rule within the conversion pattern for: math.ctlz .cttz, .absi, .expm1, .log1p, .rsqrt, .isnan, .isfinite.
> 
> What about the other Ops?

@banach-space Basically I've gone for all ops that are explicitly converted within `MathToLLVM.cpp` – apparently, the rest is fully covered by inheriting a bunch of patterns from `Vector`.

Thanks for the review Andrzej, Kunwar! If/when this is good to go in, I'd really appreciate help with the merge, as I haven't achieved write access just yet.

https://github.com/llvm/llvm-project/pull/141020


More information about the Mlir-commits mailing list