[Mlir-commits] [mlir] [MLIR][ArmSVE] Add initial lowering of vector.contract to SVE `*MMLA` instructions (PR #135636)

[Andrzej Warzyński]

banach-space wrote:

LGTM, thanks Momchil!

There's a few minor comments left from me, but these are nits (e.g. asking for more ASCII documentation) - feel free to ignore. This is the only major outstanding comment from me:

>  Additionally, the remaining tests currently use `--convert-vector-to-llvm=`, which lowers all the way to LLVM (i.e., it exercises a lot of patterns). Instead, I’d recommend testing `LowerContractionToSVEI8MMPattern` in isolation and only verifying that the correct sequence of ArmSVE ops (plus some Vector ops) is generated - for example:

Since this is effectively addressed in https://github.com/llvm/llvm-project/pull/140572, lets just proceed with this patch as is.

@dcaballe , what do you think?

https://github.com/llvm/llvm-project/pull/135636