[Mlir-commits] [mlir] [mlir][spirv] Implement UMod canonicalization for vector constants (PR #141902)

[Igor Wodiany]

IgWod-IMG wrote:

Me again :) I have two minor comments:

1) Could you please reference the issues you fix (https://github.com/llvm/llvm-project/issues/63174) in the description. In fact, if you use one of those [magic keywords](https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword) GitHub should automatically close the issue, once this change is merged.

2) It'd probably be useful to include the pattern that was broken in the tests (if not already there), so it can catch any future regression.

https://github.com/llvm/llvm-project/pull/141902