[Mlir-commits] [mlir] [mlir][linalg] Refactor vectorization hooks to improve code reuse (PR #141244)

[Andrzej Warzyński]

banach-space wrote:

Hey @Max191 , thanks for taking a lot and for your insightful comments - that's much appreciated 🙏🏻 

I totally agree with your suggestions and have made the changes accordingly. As you will notice, all the changes in the following test files have been reverted:
* `insert-slice-with-patterns.mlir`
* `pad-with-patterns.mlir`.

That's expected - these are the test files in which _we do not specify the vector sizes_, hence there should be no masking.

Re future steps:

> If it's unclear whether or not we should be doing this

Same. I intend to investigate this in the near future and might propose some changes. But I totally agree that this is quite nuanced and that we should approach this in small, incremental steps.

https://github.com/llvm/llvm-project/pull/141244