[Mlir-commits] [mlir] [mlir][vector] Improve shape_cast lowering (PR #140800)

[James Newling]

================
@@ -28,17 +28,20 @@ using namespace mlir;
 using namespace mlir::vector;
 
 /// Increments n-D `indices` by `step` starting from the innermost dimension.
-static void incIdx(SmallVectorImpl<int64_t> &indices, VectorType vecType,
+static void incIdx(MutableArrayRef<int64_t> indices, ArrayRef<int64_t> shape,
----------------
newling wrote:

I've refactored and documented this significantly in the latest commit, it is hopefully now clearer 

https://github.com/llvm/llvm-project/pull/140800